Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query parsing when using hash routing #231

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Fix query parsing when using hash routing #231

merged 2 commits into from
Oct 9, 2019

Conversation

luisrudge
Copy link
Contributor

Description

When using Single Page Frameworks with hash routing, this SDK would fail to get the query string values for the PKCE transaction.

References

Fix #225

Testing

  • This change adds test coverage for new/changed/fixed functionality

@luisrudge luisrudge added the small label Oct 1, 2019
@luisrudge luisrudge requested a review from a team October 1, 2019 01:18
@luisrudge luisrudge merged commit d2d613d into master Oct 9, 2019
@stevehobbsdev stevehobbsdev mentioned this pull request Oct 21, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 23, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 27, 2019
Merged
@stevehobbsdev stevehobbsdev deleted the fix/parse-query-hash branch March 26, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular router, useHash - results in: There are no query params available at window.location.search.
3 participants
@luisrudge @damieng @joshcanhelp